Many the fish

Results 205 comments of Many the fish

Hey @MichaScant, Thank you for the changes, However, the test CI doesn't pass. Can you fix them before we can review your PR again, please? 😄 `cargo test --locked --release...

@MichaScant, The last change to make for you is to make the CI happy; the Rustfmt is not passing; can you install and run it?

Hey @Karribalu, The first suggestion is too complex to me and breaks the API, so I would rather go with the second one !

Hey @CodeMan62, Thank you for jumping on my issue, I wasn't expecting it to be as fast! 🏎️ The first part of the job has not been merged yet: https://github.com/meilisearch/meilisearch/pull/4940...

Hey @CodeMan62, Sorry for the delay, The work is ready: https://github.com/meilisearch/meilisearch/pull/5524. The previous link is a reference branch containing the first part of the work, adding the bitflags to the...

Hey @CodeMan62, I think you've finished the first part by integrating your work: - [x] Adapt your changes to the previous work - [ ] Adapt [the authentication to compare...

Hello @Zabrane, You are right, the stopwords are case sensitive, could you retry by adding a Capitalized version of your words?

I agree with you @Zabrane, I've made a PR on the tokenizer to fix that, however, I know that it may impact the `fiters` so I'll need to check if...

Thank you @Kariton for the suggestion,I've triaged it as a relevant maintainance task, unfortunnately, I can't give you any time estimation for finishing it 😕 see you!

Hey @harshithsaiv, don't hesitate to create a PR for this