manim icon indicating copy to clipboard operation
manim copied to clipboard

tip_width and tip_height seems to have no effect on the tip size

Open dnrhead opened this issue 3 years ago • 3 comments

Description of bug / unexpected behavior

"tip_width" and "tip_height" seems to have no effect on the tip size.

Expected behavior

Size of the tip should be adjustable with "tip_width" and "tip_height".

How to reproduce the issue

plane = Axes(
            x_range = (0, 23),
            y_range = (0, 5),
            axis_config={"include_numbers": True, "include_tip": True},
            x_axis_config={"tip_width":2, "tip_height":5}  
)
plane.center()
self.add(plane)

=> "tip_width" and "tip_height" have no effect, while include_tip has an effect.

System specifications

  • OSWindows 10
  • Manim v0.14.0

dnrhead avatar Feb 21 '22 13:02 dnrhead

This seems to be an issue with how attributes are being passed into the tip constructor. Could I be assigned to this bug?

WillSoltas avatar Mar 23 '22 16:03 WillSoltas

Sure, I've assigned it to you 👍

hydrobeam avatar Mar 23 '22 17:03 hydrobeam

Hello! @WillSoltas and I have submitted a possible fix to this bug in Pull Request #2661, where we implemented the tip resize functionality according to this report specification. Would anyone be willing to take a look at the PR?

mspastrana99 avatar Apr 13 '22 20:04 mspastrana99