integration_tests icon indicating copy to clipboard operation
integration_tests copied to clipboard

[1LP][WIPTEST]Added invalid cidr/ip tests for floating_ip_add and subnet_add

Open mmojzis opened this issue 5 years ago • 3 comments

Also added needed views and create function.

mmojzis avatar Apr 01 '20 17:04 mmojzis

@jaryn are you okay to move this one to 1LP?

john-dupuy avatar Apr 09 '20 13:04 john-dupuy

Two small changes requested.

For the positive flash message, I'd accept this PR with just a flash.assert_no_error in the create method and no positive flash message text assertion.

@jawatts @mshriver These tests are only negative. It should check the format of flash message when invalid cidr is filled in. I added these tests only because there was qe_test_coverage needed for these BZs. I understand that you also want positive test that passes, but I didn't have qe_test_coverage for that. I have no more time to write positive test.

mmojzis avatar Apr 27 '20 13:04 mmojzis

I detected some fixture changes in commit 18e93fb79779d64ad9b29d3002a2ba8f8b72c645

The local fixture network_manager is used in the following files:

  • cfme/tests/networks/test_sdn_subnets.py
    • test_network_subnet_invalid_cidr

Please, consider creating a PRT run to make sure your fixture changes do not break existing usage :smiley:

dajoRH avatar Apr 27 '20 13:04 dajoRH