Zero icon indicating copy to clipboard operation
Zero copied to clipboard

fix: update docker commands in package.json to use 'docker compose' syntax

Open SerhiiMandrykin opened this issue 8 months ago • 2 comments

Description

This PR updates the Docker commands within the scripts section of package.json. Specifically, it replaces the legacy docker-compose command (with hyphen) with the modern docker compose syntax (with space) for the docker:up, docker:down, and docker:clean scripts.

This change aligns the project with current Docker best practices and ensures compatibility with newer Docker versions that prioritize the integrated compose command.


Type of Change

  • [x] 🐛 Bug fix (non-breaking change which fixes an issue) (Fixes usage of deprecated command syntax)

Areas Affected

  • [x] Development Workflow

Testing Done

  • [x] Manual testing performed (Verified that bun run docker:up, bun run docker:down, and bun run docker:clean execute correctly using the new docker compose syntax.)

Security Considerations

  • [x] No sensitive data is exposed (This change modifies script commands and does not directly handle data or authentication.)

Checklist

  • [x] I have read the CONTRIBUTING document
  • [x] My code follows the project's style guidelines
  • [x] I have performed a self-review of my code
  • [ ] I have commented my code, particularly in complex areas (N/A for this change)
  • [ ] I have updated the documentation (Assuming no docs update needed)
  • [x] My changes generate no new warnings
  • [ ] I have added tests that prove my fix/feature works (N/A - testing done manually)
  • [x] All tests pass locally (Assuming manual tests passed)
  • [ ] Any dependent changes are merged and published (Assuming no dependencies)

Additional Notes

This update ensures the project uses the standard Docker Compose V2 command syntax, improving maintainability and alignment with Docker tooling updates.

Screenshots/Recordings

(N/A for this change)


By submitting this pull request, I confirm that my contribution is made under the terms of the project's license.

Summary by CodeRabbit

  • Chores
    • Updated Docker-related commands in npm scripts to use the latest docker compose syntax instead of the deprecated docker-compose command.

SerhiiMandrykin avatar May 12 '25 13:05 SerhiiMandrykin

@SerhiiMandrykin is attempting to deploy a commit to the Zero Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar May 12 '25 13:05 vercel[bot]

Walkthrough

The npm scripts in package.json related to Docker operations were updated to use the newer docker compose command syntax instead of the deprecated docker-compose command. No other scripts or dependencies were modified.

Changes

File Change Summary
package.json Updated Docker scripts: replaced docker-compose with docker compose in up, down, and clean scripts.

Poem

🐇
Compose commands got a shiny new face,
With spaces instead of the old hyphen place.
Up, down, and clean—so tidy and neat,
Docker scripts now skip a deprecated beat.
A hop and a skip, the change is complete!

[!TIP]

⚡️ Faster reviews with caching
  • CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.

Enjoy the performance boost—your workflow just got faster.


📜 Recent review details

Configuration used: CodeRabbit UI Review profile: CHILL Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6c38a4c5829b91d18d059e25aa9d3b730c97cb78 and 85d201a7ac3dddd8d077e5b4cfa82bfd3b712ce5.

📒 Files selected for processing (1)
  • package.json (1 hunks)
🔇 Additional comments (1)
package.json (1)

17-19: Use modern docker compose syntax
The updated scripts correctly replace the deprecated docker-compose wrapper with the integrated docker compose CLI, aligning with Docker Compose V2 best practices.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar May 12 '25 13:05 coderabbitai[bot]

please revise, staging should be base branch

MrgSub avatar May 12 '25 18:05 MrgSub

Ok, I will create a new one, thx

SerhiiMandrykin avatar May 13 '25 07:05 SerhiiMandrykin

New is #965

SerhiiMandrykin avatar May 13 '25 07:05 SerhiiMandrykin