Zero icon indicating copy to clipboard operation
Zero copied to clipboard

Feat. Enable Attachment preview + PDF VIEWER

Open kingstondoesit opened this issue 9 months ago • 11 comments

msedge_30gTpWwM4D

Type of Change

  • [x] ✨ New feature (non-breaking change which adds functionality)
  • [x] 🎨 UI/UX improvement

Areas Affected

  • [x] User Interface/Experience

Testing Done

Describe the tests you've done:

  • [x] Manual testing performed
  • [x] Mobile responsiveness verified (if UI changes)

Security Considerations

For changes involving data or authentication:

  • [X] No sensitive data is exposed

Checklist

  • [x] I have read the CONTRIBUTING document
  • [x] My code follows the project's style guidelines
  • [x] I have performed a self-review of my code
  • [x] I have commented my code, particularly in complex areas
  • [x] My changes generate no new warnings
  • [x] All tests pass locally
  • [x] Any dependent changes are merged and published

Additional Notes

Add any other context about the pull request here.

Screenshots/Recordings

Add screenshots or recordings here if applicable.


By submitting this pull request, I confirm that my contribution is made under the terms of the project's license.

kingstondoesit avatar Apr 28 '25 10:04 kingstondoesit

@kingstondoesit is attempting to deploy a commit to the Zero Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Apr 28 '25 10:04 vercel[bot]

[!IMPORTANT]

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Apr 28 '25 10:04 coderabbitai[bot]

hey @kingstondoesit can we make the dialog a little taller? maybe put a min-height on it so we can see more of the pdf when it is open? can only see about half a page at a time currently. CleanShot 2025-04-28 at 12 49 12

ahmetskilinc avatar Apr 28 '25 11:04 ahmetskilinc

hey @kingstondoesit can we make the dialog a little taller? maybe put a min-height on it so we can see more of the pdf when it is open? can only see about half a page at a time currently. CleanShot 2025-04-28 at 12 49 12

Damn. I hadn't tried with larger pdf page sizes. maybe implementing a maximum pdf view width and disabling the scroller in the horizontal direction might fix this. What do you suggest?

kingstondoesit avatar Apr 28 '25 12:04 kingstondoesit

Experimenting now...

kingstondoesit avatar Apr 28 '25 12:04 kingstondoesit

@ahmetskilinc. Can you test again with the passport?

image image image

kingstondoesit avatar Apr 29 '25 15:04 kingstondoesit

Zooming in messes everything up. I've shown it in the video.

https://github.com/user-attachments/assets/5cdf59b1-66ce-4394-aa3b-170da5857ac3

ahmetskilinc avatar Apr 29 '25 15:04 ahmetskilinc

Zooming in messes everything up. I've shown it in the video.

CleanShot.2025-04-29.at.16.30.12.mp4

Yeah I've noticed this, Still a WIP. Ideally dialog header and zoom/nav controls got to be static. Will fix

kingstondoesit avatar Apr 29 '25 15:04 kingstondoesit

marking as draft so not to get confused

ahmetskilinc avatar Apr 29 '25 17:04 ahmetskilinc

@ahmetskilinc. think this should be good for now about time I officially handed over the design baton for this to you or @nizzyabi

msedge_gQahMtgdtS

kingstondoesit avatar Apr 30 '25 15:04 kingstondoesit

@nizzyabi I do suggest getting a license from https://showcase.apryse.com

https://www.npmjs.com/package/@pdftron/webviewer

Xytronix avatar May 02 '25 13:05 Xytronix