Zero icon indicating copy to clipboard operation
Zero copied to clipboard

DOs for storage

Open MrgSub opened this issue 7 months ago β€’ 2 comments

READ CAREFULLY THEN REMOVE

Remove bullet points that are not relevant.

PLEASE REFRAIN FROM USING AI TO WRITE YOUR CODE AND PR DESCRIPTION. IF YOU DO USE AI TO WRITE YOUR CODE PLEASE PROVIDE A DESCRIPTION AND REVIEW IT CAREFULLY. MAKE SURE YOU UNDERSTAND THE CODE YOU ARE SUBMITTING USING AI.

  • Pull requests that do not follow these guidelines will be closed without review or comment.
  • If you use AI to write your PR description your pr will be close without review or comment.
  • If you are unsure about anything, feel free to ask for clarification.

Description

Please provide a clear description of your changes.


Type of Change

Please delete options that are not relevant.

  • [ ] πŸ› Bug fix (non-breaking change which fixes an issue)
  • [ ] ✨ New feature (non-breaking change which adds functionality)
  • [ ] πŸ’₯ Breaking change (fix or feature with breaking changes)
  • [ ] πŸ“ Documentation update
  • [ ] 🎨 UI/UX improvement
  • [ ] πŸ”’ Security enhancement
  • [ ] ⚑ Performance improvement

Areas Affected

Please check all that apply:

  • [ ] Email Integration (Gmail, IMAP, etc.)
  • [ ] User Interface/Experience
  • [ ] Authentication/Authorization
  • [ ] Data Storage/Management
  • [ ] API Endpoints
  • [ ] Documentation
  • [ ] Testing Infrastructure
  • [ ] Development Workflow
  • [ ] Deployment/Infrastructure

Testing Done

Describe the tests you've done:

  • [ ] Unit tests added/updated
  • [ ] Integration tests added/updated
  • [ ] Manual testing performed
  • [ ] Cross-browser testing (if UI changes)
  • [ ] Mobile responsiveness verified (if UI changes)

Security Considerations

For changes involving data or authentication:

  • [ ] No sensitive data is exposed
  • [ ] Authentication checks are in place
  • [ ] Input validation is implemented
  • [ ] Rate limiting is considered (if applicable)

Checklist

  • [ ] I have read the CONTRIBUTING document
  • [ ] My code follows the project's style guidelines
  • [ ] I have performed a self-review of my code
  • [ ] I have commented my code, particularly in complex areas
  • [ ] I have updated the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix/feature works
  • [ ] All tests pass locally
  • [ ] Any dependent changes are merged and published

Additional Notes

Add any other context about the pull request here.

Screenshots/Recordings

Add screenshots or recordings here if applicable.


By submitting this pull request, I confirm that my contribution is made under the terms of the project's license.

MrgSub avatar Jun 27 '25 00:06 MrgSub

This stack of pull requests is managed by Graphite. Learn more about stacking.

MrgSub avatar Jun 27 '25 00:06 MrgSub

[!CAUTION]

Review failed

The pull request is closed.

Walkthrough

This update introduces a local database-backed caching layer for email threads, enabling label-based filtering and improved synchronization between server and client. Major changes include new hooks and schemas for label management, modifications to thread retrieval and synchronization logic, and updates to API procedures to utilize the local cache. Several files are refactored for type safety and consistency.

Changes

File(s) Change Summary
apps/mail/components/mail/mail-list.tsx Updated thread container class to apply conditional opacity based on read status using the cn utility.
apps/mail/components/mail/mail.tsx Commented out category selector for Google inbox and adjusted container height calculation for medium screens.
apps/mail/components/party.tsx Added enums for message types and simplified message handling logic for mail thread updates.
apps/mail/components/ui/recursive-folder.tsx Switched from string-based to ID-based label filtering using a new useSearchLabels hook.
apps/mail/hooks/use-labels-search.ts Introduced useSearchLabels hook for managing label IDs in URL query state.
apps/mail/hooks/use-threads.ts Integrated label-based filtering into thread queries using useSearchLabels.
apps/server/src/lib/driver/google.ts Ensured attachment headers are always objects with string name and value fields.
apps/server/src/lib/driver/types.ts Made latest property in IGetThreadResponse optional and added a Zod schema for validation.
apps/server/src/lib/server-utils.ts Refactored notifyUser to use explicit result and threadId parameters and simplified notification construction.
apps/server/src/main.ts Prefixed scheduled task logs with [SCHEDULED] for clarity.
apps/server/src/pipelines.ts Added notification after thread retrieval in ThreadWorkflow using notifyUser.
apps/server/src/routes/chat.ts Implemented SQLite-based thread caching, synchronization methods, and updated message handling to use the cache.
apps/server/src/trpc/routes/mail.ts Updated procedures to use database-backed thread retrieval, added label filtering, and refined type handling.
apps/server/src/types.ts Replaced ParsedMessage interface with a Zod schema and derived type alias for validation and type safety.
apps/server/wrangler.jsonc Added R2 bucket bindings for thread storage in all environments.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant TRPC
    participant AgentRpcDO
    participant ZeroAgent
    participant SQLite
    participant KV
    participant MailDriver

    Client->>TRPC: listThreads({ labelIds, ... })
    TRPC->>AgentRpcDO: getThreadsFromDB({ labelIds, ... })
    AgentRpcDO->>ZeroAgent: getThreadsFromDB({ labelIds, ... })
    ZeroAgent->>SQLite: Query threads table (with label/folder filters)
    SQLite-->>ZeroAgent: Thread metadata rows
    ZeroAgent-->>AgentRpcDO: Thread IDs and pagination token
    AgentRpcDO-->>TRPC: Thread list
    TRPC-->>Client: Thread list

    Client->>TRPC: get(threadId)
    TRPC->>AgentRpcDO: getThreadFromDB(threadId)
    AgentRpcDO->>ZeroAgent: getThreadFromDB(threadId)
    ZeroAgent->>SQLite: Query threads table for threadId
    alt Thread found
        ZeroAgent->>KV: Get messages for threadId
        KV-->>ZeroAgent: Messages
        ZeroAgent-->>AgentRpcDO: Thread data
    else Thread not found
        ZeroAgent->>MailDriver: Fetch thread
        MailDriver-->>ZeroAgent: Thread data
        ZeroAgent->>KV: Store messages
        ZeroAgent->>SQLite: Insert thread metadata
        ZeroAgent-->>AgentRpcDO: Thread data
    end
    AgentRpcDO-->>TRPC: Thread data
    TRPC-->>Client: Thread data

Possibly related PRs

  • Mail-0/Zero#387: Refactors useThreads for type safety and memoization; related due to both PRs modifying thread fetching and rendering logic.
  • Mail-0/Zero#402: Adjusts layout styling in mail components; related as both PRs modify UI styling in MailLayout.
  • Mail-0/Zero#1212: Adds and updates enums for message types in party.tsx; related due to shared message handling logic.

Suggested reviewers

  • nizzyabi

Poem

Hopping through code with a cache so neat,
Threads now sync and labels compete.
SQLite burrows, R2 stores,
Filtering mail through clever doors.
With Zod and hooks, the logic's tightβ€”
A rabbit’s delight, inboxes light!
πŸ‡πŸ’Œ


πŸ“œ Recent review details

Configuration used: CodeRabbit UI Review profile: CHILL Plan: Pro

πŸ“₯ Commits

Reviewing files that changed from the base of the PR and between c86fefa51e9da1262b03c59ee9ea9d300fcdef93 and 66cb890fbf505185f34826bd93b302845e7450b5.

πŸ“’ Files selected for processing (15)
  • apps/mail/components/mail/mail-list.tsx (1 hunks)
  • apps/mail/components/mail/mail.tsx (2 hunks)
  • apps/mail/components/party.tsx (2 hunks)
  • apps/mail/components/ui/recursive-folder.tsx (2 hunks)
  • apps/mail/hooks/use-labels-search.ts (1 hunks)
  • apps/mail/hooks/use-threads.ts (2 hunks)
  • apps/server/src/lib/driver/google.ts (1 hunks)
  • apps/server/src/lib/driver/types.ts (1 hunks)
  • apps/server/src/lib/server-utils.ts (2 hunks)
  • apps/server/src/main.ts (4 hunks)
  • apps/server/src/pipelines.ts (2 hunks)
  • apps/server/src/routes/chat.ts (10 hunks)
  • apps/server/src/trpc/routes/mail.ts (6 hunks)
  • apps/server/src/types.ts (2 hunks)
  • apps/server/wrangler.jsonc (6 hunks)
✨ Finishing Touches
  • [ ] πŸ“ Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❀️ Share
πŸͺ§ Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Jun 27 '25 00:06 coderabbitai[bot]

Merge activity

  • Jun 27, 2:44 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jun 27, 2:45 AM UTC: @MrgSub merged this pull request with Graphite.

MrgSub avatar Jun 27 '25 02:06 MrgSub