Zero icon indicating copy to clipboard operation
Zero copied to clipboard
verified publisher icon Mail-0

refactor(nav): enhance account switcher

Open hiheyhello123 opened this issue 7 months ago • 1 comments

Summary by CodeRabbit

  • New Features
    • Introduced a global loading indicator with animated overlay and customizable messages for improved user feedback during operations.
  • Improvements
    • Enhanced account switching with explicit loading states, improved cache management, and clearer success or error notifications.
    • Added new localized messages for account switching status.
  • Chores
    • Updated package manager version for improved tooling support.

hiheyhello123 avatar Jun 19 '25 02:06 hiheyhello123

Walkthrough

A new loading context with provider and hook was implemented for managing global loading states in the mail app. The account-switching logic in the navigation user component was refactored to utilize this context, with improved cache handling and user feedback. New localization strings were added, and the provider hierarchy was updated to include the loading context.

Changes

File(s) Change Summary
apps/mail/components/context/loading-context.tsx Added LoadingProvider, LoadingContext, useLoading hook, and LoadingContextType interface for global loading state.
apps/mail/components/ui/nav-user.tsx Refactored handleAccountSwitch to use loading context, improved cache invalidation, updated imports.
apps/mail/locales/en.json Added three new localization strings for account switching messages.
apps/mail/providers/client-providers.tsx Wrapped children and Toaster in LoadingProvider within PostHogProvider.
package.json Updated pnpm version from 10.11.0 to 10.12.1.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant NavUser
    participant LoadingProvider
    participant QueryCache
    participant Toast

    User->>NavUser: Switch account
    NavUser->>LoadingProvider: setLoading(true, "Switching accounts...")
    NavUser->>QueryCache: Set default connection, update cache
    NavUser->>QueryCache: Invalidate/remove relevant caches
    alt Success
        NavUser->>Toast: Show success message
    else Failure
        NavUser->>Toast: Show error message
        NavUser->>QueryCache: Refetch active connection
    end
    NavUser->>LoadingProvider: setLoading(false)

Suggested reviewers

  • needleXO
  • ahmetskilinc

Poem

A spinner whirls, a context grows,
Loading states now neatly show.
Switch accounts with seamless grace,
Toasts and messages in their place.
Providers stack, the cache is clean,
The rabbit hops where code is seen! 🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI Review profile: CHILL Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7243120c918db3ba3b58b913641977de931527e7 and b10b5c7b873a1e8eeac223703a2c02805e882fb7.

📒 Files selected for processing (5)
  • apps/mail/components/context/loading-context.tsx (1 hunks)
  • apps/mail/components/ui/nav-user.tsx (3 hunks)
  • apps/mail/locales/en.json (1 hunks)
  • apps/mail/providers/client-providers.tsx (2 hunks)
  • package.json (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • package.json
🚧 Files skipped from review as they are similar to previous changes (4)
  • apps/mail/providers/client-providers.tsx
  • apps/mail/locales/en.json
  • apps/mail/components/context/loading-context.tsx
  • apps/mail/components/ui/nav-user.tsx
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: Analyze (actions)
✨ Finishing Touches
  • [ ] 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Jun 19 '25 02:06 coderabbitai[bot]

This stack of pull requests is managed by Graphite. Learn more about stacking.

MrgSub avatar Jun 21 '25 19:06 MrgSub

Merge activity

  • Jun 21, 8:02 PM UTC: Graphite rebased this pull request as part of a merge.
  • Jun 21, 8:03 PM UTC: @MrgSub merged this pull request with Graphite.

MrgSub avatar Jun 21 '25 20:06 MrgSub