Zero icon indicating copy to clipboard operation
Zero copied to clipboard
verified publisher icon Mail-0

better command palette and new shortcuts

Open ahmetskilinc opened this issue 8 months ago • 2 comments

TL;DR

Refactored the command palette to improve the search and filter experience in the mail app.

What changed?

  • Restructured the CommandPaletteProvider to wrap the entire mail app layout
  • Enhanced the command palette context to expose active filters and a clear filters function
  • Replaced the search bar with an improved command palette button that displays active filters
  • Added a "Clear" button directly in the search UI to quickly remove all filters
  • Added a new keyboard shortcut (Cmd+Shift+F) to clear all filters
  • Removed the '/' shortcut for search in favor of using Cmd+K for the command palette

How to test?

  1. Open the mail app and press Cmd+K to open the command palette
  2. Apply some filters through the command palette
  3. Verify that active filters appear in the search bar
  4. Test clearing filters using:
    • The "Clear" button next to the filters
    • The Cmd+Shift+F keyboard shortcut
  5. Verify that the command palette opens correctly with Cmd+K

Why make this change?

This change improves the user experience by:

  • Making active filters more visible in the UI
  • Providing multiple ways to clear filters
  • Streamlining the search and filter workflow
  • Creating a more consistent command interface throughout the application

Summary by CodeRabbit

  • New Features
    • Added a global keyboard shortcut (Cmd+Shift+F) to clear all active filters in the mail app.
  • Refactor
    • Streamlined the command palette and its provider for improved context management and simplified state handling.
    • Updated the mail layout to use a button for opening the command palette, displaying active filters and providing quick access to clearing filters.
  • Style
    • Improved button and filter UI styling for better clarity and usability.
  • Bug Fixes
    • Removed the single-key '/' search shortcut to prevent accidental activation.

ahmetskilinc avatar May 30 '25 21:05 ahmetskilinc

"""

Walkthrough

The changes refactor the command palette system in the mail application. A new CommandPaletteProvider wraps the layout, context provision is consolidated, hotkey handling is updated, and UI logic for opening and clearing filters is moved to the mail component. Global shortcuts are adjusted to match the new structure.

Changes

File(s) Change Summary
apps/mail/app/(routes)/layout.tsx Added CommandPaletteProvider as a wrapper around the layout's content.
apps/mail/components/context/command-palette-context.tsx Refactored CommandPalette to accept children and manage context; simplified CommandPaletteProvider; removed unused imports and button.
apps/mail/components/mail/mail.tsx Replaced direct CommandPalette usage with a button that toggles palette via context; added filter display and clear logic.
apps/mail/config/shortcuts.ts Removed '/' search shortcut; added 'mod+shift+f' global shortcut for clearing all filters.
apps/mail/lib/hotkeys/global-hotkeys.tsx Updated to use useCommandPalette for hotkey handlers; removed search handler; added command palette and clear filters handlers.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant MailComponent
    participant CommandPaletteContext
    participant CommandPaletteProvider
    participant GlobalHotkeys

    User->>MailComponent: Clicks "Search & Filters" button or uses hotkey
    MailComponent->>CommandPaletteContext: setOpen(true)
    CommandPaletteContext->>CommandPaletteProvider: Opens command palette UI

    User->>GlobalHotkeys: Presses 'mod+shift+f'
    GlobalHotkeys->>CommandPaletteContext: clearAllFilters()
    CommandPaletteContext->>MailComponent: Filters are cleared

Possibly related PRs

  • Mail-0/Zero#1154: Modifies the same command palette components and context provider usage, but in the opposite direction, making the changes directly related.

Suggested reviewers

  • MrgSub

Poem

In the warren where hotkeys hop,
A palette blooms atop the crop.
With filters cleared and shortcuts new,
The rabbits code a UI true.
Buttons shimmer, mod keys dance,
Context wraps the mail’s expanse.
🐇✨ """

📜 Recent review details

Configuration used: CodeRabbit UI Review profile: CHILL Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 851ddf68da4676de2bbee91f272fad519c982678 and f18f1b3d34d84301a5319cd7a74910e152b84cd0.

📒 Files selected for processing (5)
  • apps/mail/app/(routes)/layout.tsx (1 hunks)
  • apps/mail/components/context/command-palette-context.tsx (6 hunks)
  • apps/mail/components/mail/mail.tsx (3 hunks)
  • apps/mail/config/shortcuts.ts (1 hunks)
  • apps/mail/lib/hotkeys/global-hotkeys.tsx (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (5)
  • apps/mail/app/(routes)/layout.tsx
  • apps/mail/lib/hotkeys/global-hotkeys.tsx
  • apps/mail/config/shortcuts.ts
  • apps/mail/components/context/command-palette-context.tsx
  • apps/mail/components/mail/mail.tsx
✨ Finishing Touches
  • [ ] 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar May 30 '25 21:05 coderabbitai[bot]

This stack of pull requests is managed by Graphite. Learn more about stacking.

ahmetskilinc avatar May 30 '25 21:05 ahmetskilinc

Merge activity

  • Jun 1, 2:48 AM UTC: Graphite rebased this pull request as part of a merge.
  • Jun 1, 2:49 AM UTC: @ahmetskilinc merged this pull request with Graphite.

ahmetskilinc avatar Jun 01 '25 02:06 ahmetskilinc