MaibornWolff
Bug/3044/margin renders some buildings missing
Modify area calculation to prevent disappearing buildings
Please read the CONTRIBUTING.md before opening a PR.
closes: #3044
Description
- Change algorithm to visualize buildings that are getting removed by margin
- Make margin scale with map size
- Change floor label calculation to prevent floor labels that are "sandwitched" between bigger folders from rendering without buildings
- add tests to explain new behaviour
- maps are now quite bigger to assure that all buildings fit
- sizes of folder areas should now more closely match each other when they are the same size
Screenshots or gifs
However, I am still unhappy with the floor label solution and what be glad for any feedback or the potential to discuss it
I would appreciate your feedback, now that maps are again squares and big maps are scaled down a bit
Also for the changed floor label criteria and overall applicability for presentations
[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed! 
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
No Duplication information
![sonarqubecloud[bot] avatar](https://avatars.githubusercontent.com/in/12526?v=4 "Published by a pub.dev verified publisher"){kind=small}
[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
4 Code Smells
96.1% Coverage
0.0% Duplication
Hey, what's the status here @ the whole team? This PR is open for a pretty long time by now and we should try to get it merged soon, if there's no blocker left?
In my experience there is no blocker I stated that it disables "Invert Area" but the feature was not working beforehand so we would need to reimplement it anyway
@RomanenkoVladimir I did some tests:
- Loading anon.cc.json will cause an endless loop with a lots of console errors.
- Why are some labels missing in the amazonaws.cc.json map?
@RomanenkoVladimir I did some tests:
- Loading anon.cc.json will cause an endless loop with a lots of console errors
- Why are some labels missing in the amazonaws.cc.json map?
I don’t know about the anon.cc.json map, I take a look
but missing labels is part of the behavior, the folders were probably too small in contrast to the overall size or the parent folder sizes
I also focused a file that is not rendered in CC map. The following error occured but I think it is already fixed by #3126.
I also focused a file that is not rendered in CC map. The following error occured but I think it is already fixed by #3126.
Yeah it should not be possible to focus unrendered files, on main
Loading a fixed folder map will crash the app. What's the status here? I am not sure how to deal with that to find a workaround at the moment. One option would be to deactivate the floor labels for maps of these type. But that has to be discussed internally first.
Loading a fixed folder map will crash the app. What's the status here? I am not sure how to deal with that to find a workaround at the moment. One option would be to deactivate the floor labels for maps of these type. But that has to be discussed internally first.
I fix it tonight, it’s an easy fix I am sure I know what broke it
It is looking good to me. We should check one last thing.
With experimental features = on, the anon.cc.json is crashing with the following errors:
[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
No Duplication information
[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
4 Code Smells
96.6% Coverage
0.0% Duplication
Dear team, I would like to celebrate fixing this somehow. Do you have a suggestion what you would like to do or would you rather not do anything special?
It is looking good to me. We should check one last thing. With experimental features = on, the anon.cc.json is crashing with the following errors:
@MW-Friedrich Did you have a look on that?
It is looking good to me. We should check one last thing. With experimental features = on, the anon.cc.json is crashing with the following errors:
@MW-Friedrich Did you have a look on that?
Yes, I did, and I unfortunately couldn't reproduce the error. The anon.cc.json is the file that is loaded when starting CodeCarta in development mode (npm run dev), right?
Ah okay. No, the anon.cc.json is another file that is shared internally. I will provide you with the map.
Ah okay. No, the anon.cc.json is another file that is shared internally. I will provide you with the map.
I found and fixed the error together with @BenediktMehl in another issue, since we found out that the error had nothing to do with the margins. Good catch though!
Ah okay. No, the anon.cc.json is another file that is shared internally. I will provide you with the map.
I found and fixed the error together with @BenediktMehl in another issue, since we found out that the error had nothing to do with the margins. Good catch though!
Thank you. This was fixed in #3144