codecharta icon indicating copy to clipboard operation
codecharta copied to clipboard

Margin renders some buildings invisible

Open RomanenkoVladimir opened this issue 3 years ago • 2 comments

Bug

Due to D3's algorithm using margins between buildings removes small buildings entirely as they are not calculated, furthermore sizes are not correct, e.g. a buildings of size 400 is not 4 times larger then a building of size 100.

Expected Behavior

All buildings are calculated and placed on the map <GIVEN> A CodeCharta map with small buildings WHEN the map is visualized THEN all buildings are displayed with correct sizes

Actual Behavior

sizes are incorrect and some are not displayed at all

Specifications

Notes

Part 1 of the refactoring for PR for issue #1609

RomanenkoVladimir avatar Sep 20 '22 11:09 RomanenkoVladimir

Sorry wrong PR

phanlezz avatar Nov 04 '22 11:11 phanlezz

I think the issue might be a result of using Math.cell() to often, please take a look and remove all intermediate usage by only applying it in the end instead :)

RomanenkoVladimir avatar Dec 02 '22 16:12 RomanenkoVladimir