MagicMirror icon indicating copy to clipboard operation
MagicMirror copied to clipboard

newsfeed enclosured picture feature

Open bugsounet opened this issue 1 year ago • 6 comments

Hi, i plan to add to newsfeed default module an enclosured picture of the item displayed.

What do you think about this feature?

bugsounet avatar May 10 '24 21:05 bugsounet

more info.. enclosure picture of the item displayed

doesn't mean anything to me..

give examples.. does this mean it can't fit on the bottom_center anymore (too tall?)

sdetweil avatar May 10 '24 22:05 sdetweil

The picture like this (example of one of my modules):

many feed have an enclosured picture related of article why not display it ?

bugsounet avatar May 12 '24 08:05 bugsounet

ok, got it now.

I personally don't think the base should take on this kind of technical debt. That's what the 3rd party ecosystem is for. we give examples of what can be done in a functional way, we don't do every solution.

sdetweil avatar May 12 '24 16:05 sdetweil

ok, it's just a proposal ;)

bugsounet avatar May 12 '24 22:05 bugsounet

I wouldnt close it so fast, cause I like the idea. We always add new functionality to our code modules, so why not this? Maybe disable it per default, so the "slick" look is preserved.

rejas avatar May 13 '24 09:05 rejas

@rejas: Ok, i will see

bugsounet avatar May 18 '24 14:05 bugsounet

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Oct 05 '24 18:10 github-actions[bot]