JournalWatcher probably should not inherit from FileSystemWatcher

[barrywimlett]

This strikes me as a classic 'has a' vs 'Is a' design issue.

Having checked through the code the only thing that "breaks" is that the void Parse(string line) method (ab)uses the FileSystemWatchers OnError method to indicate that errors have occoured either parsing the json or in an external eventhandler processing the event ( we probably out to separate out those two cases ).

By inheriting from FileSystemWatcher you expose its internals to consumers of JournalWatcher, changes to these properties are more likely to break JournalWatcher functionality than allow consumers enhance their experience.

Hiding the FSW inside makes potentially things less complicated for consumers.

[barrywimlett]

Under development

https://github.com/barrywimlett/EliteJournalReader/tree/RemoveFileSystemWatcherInheritance

@MagicMau I am aware that you consumer this project in the G19 Keyboard app for ED - does this use any of the 'exposed' parts of he FileSystemWatcer