madanalysis5 icon indicating copy to clipboard operation
madanalysis5 copied to clipboard

Issue in boost()

Open ajueid opened this issue 2 years ago • 2 comments

System Settings

All operating systems

Describe the bug

There was a problem with void boost(MALorentzVector &p) {} (Line 146 in MABoost.h). The old function does not properly boost the Lorentz vector. Below you can find a fix

void boost(MALorentzVector &p) const { MAdouble64 bp = bx_ * p.X() + by_ * p.Y() + bz_ * p.Z(); p.SetX(p.X() - gamma_ * bx_ * p.T() + (gamma_ - 1) * bx_ * bp / b2_); p.SetY(p.Y() - gamma_ * by_ * p.T() + (gamma_ - 1) * by_ * bp / b2_); p.SetZ(p.Z() - gamma_ * bz_ * p.T() + (gamma_ - 1) * bz_ * bp / b2_); p.SetT(gamma_ * (p.T() - bp)); }

To Reproduce

All modes

Expected behaviour

No response

Log files

No response

Additional information

No response

ajueid avatar Feb 12 '24 07:02 ajueid

Hi @ajueid, could you explain what the problem is?

jackaraz avatar Feb 13 '24 17:02 jackaraz

In the code, there is gamma^2 instead of gamma.

Cheers,

Benj

On 13 Feb 2024, at 18:31, Jack Y. Araz @.***> wrote:

Hi @ajueid https://github.com/ajueid, could you explain what the problem is?

— Reply to this email directly, view it on GitHub https://github.com/MadAnalysis/madanalysis5/issues/244#issuecomment-1942065431, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIWJNJ3XUW6ZN2CCKLSNTADYTOPOLAVCNFSM6AAAAABDEHK662VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBSGA3DKNBTGE. You are receiving this because you are subscribed to this thread.

BFuks avatar Feb 13 '24 19:02 BFuks