macdown icon indicating copy to clipboard operation
macdown copied to clipboard

Small improvements

Open insidegui opened this issue 11 years ago • 5 comments

I've noticed that the webview's scrolling was a little choppy, that improves dramatically when you turn on layer backed mode on the view hierarchy.

Also, I've implemented the functionality to detach the preview from the editor, I only tested It on Yosemite, so It would be a good idea to test in previous versions before merging to make sure It's working fine.

insidegui avatar Jan 01 '15 16:01 insidegui

This is awesome. :smile:

Could you split the two things into two different pull requests? I can merge the scrolling things quickly, but the detached view part will need more testing.

uranusjr avatar Jan 02 '15 04:01 uranusjr

The scrolling thing you can do yourself, It's just a checkbox :D

calayer

insidegui avatar Jan 02 '15 13:01 insidegui

I know, but if I do that myself there will likely be conflicts when this is merged. But that’s nothing big—I’ll just tick it now. :smiley:

uranusjr avatar Jan 02 '15 16:01 uranusjr

I’ve (finally) tried this, and the compatibility seems to be fine (tested on 10.9, and all API should work on 10.8 unless my eyes failed me). I have a minor usability issue though: When the preview is detached, the editor would fill main document window, and I need to resize it to make it able to display side-by-side with the preview pane. I would expect the editor to keep its size (thus make the main window narrower than before). Likewise, when I attach the preview pane back, the document window should grow automatically to fit the preview. I’m not exactly sure what is the best way to do this, to be honest, but the current behaviour doesn’t seem right.

cc @mtford90

uranusjr avatar Jan 19 '15 16:01 uranusjr

An update with the Core Animation thing: The new setting seems to cause #253, which is unacceptable. I’ve reverted the change. We will have to find another way to do this (without causing the same problem; it seems to happen whenever you sets wantsLayer = YES on the web view).

uranusjr avatar Jan 29 '15 12:01 uranusjr