MMapper icon indicating copy to clipboard operation
MMapper copied to clipboard

Initial support for MUME's room id

Open cosmos72 opened this issue 2 years ago • 4 comments

Parses MUME's room id into a newly created class RoomServerId, and also adds a RoomServerId field to relevant classes: Room and ParseEvent.

Definitely NOT complete, but it's a first step.

The path machine code definitely needs review from someone who knows it better than me.

cosmos72 avatar Apr 03 '23 17:04 cosmos72

I've been following this merge request, but there's been no activity. What are the next steps here @nschimme ? I feel support for MUME's room ids is the most important feature in the potential pipeline for MMapper right now...

Sebster7 avatar Sep 05 '23 14:09 Sebster7

I'll try to answer while waiting for @nschimme take on this: This patch only contains the bare minimum needed to receive, extract and pass around MUME room ids.

The next step is extending path machine algorithms to add MUME room ids as a very high priority/confidence source of location info. Unluckily, the path machine is definitely complicated and I currently don't have the time to study it - someone else (@nschimme ?) will be needed to extend it.

cosmos72 avatar Sep 12 '23 21:09 cosmos72

Thanks for your reply @cosmos72. I'd say that it would be good to get in the parsing and saving of the current room id to the map (where the current location is known with a high degree of certainty using the existing algorithm), and ignore everything else GMCP-related (as that may - or should - yet change), and including the path machine stuff. This way, people can start to get their maps updated (as the default map having this is sort of a blocker on #306 ).

Sebster7 avatar Sep 18 '23 22:09 Sebster7

Hi @Sebster7, that was exactly my thought when I started adding support for room ids.

Although, it turned out that this means reconciling room ids with the other mechanisms used by path machine for recognizing and identifying rooms.

So you still have to modify the path machine, although the changes are probably simpler: after all, the intention is to only WRITE room ids into room, not to READ them back and use them as an additional source of truth inside path machine algorithm.

cosmos72 avatar Sep 20 '23 09:09 cosmos72

Merged as part of db0806068d72f81af8bc26df9607a250bf066ed1

nschimme avatar Apr 15 '25 16:04 nschimme