MITgcm icon indicating copy to clipboard operation
MITgcm copied to clipboard

typos found along the way (2025)

Open IvanaEscobar opened this issue 8 months ago • 3 comments

What changes does this PR introduce?

Updating spelling in miscellaneous parts of source code

What is the current behaviour?

Typos in comments

What is the new behaviour

No typos in comments

Does this PR introduce a breaking change?

No

Other information:

Suggested addition to tag-index

simple spell checking

IvanaEscobar avatar Jun 02 '25 13:06 IvanaEscobar

@IvanaEscobar, @jm-c noted other errors and bigger issues with the doc in dynamics.F and was going to expand the scope of this PR to improve (hence delaying merger a bit)

jrscott avatar Jun 04 '25 18:06 jrscott

Ok, this PR isn't meant to be more than a light pass to fix obvious typos I've discovered over the last few months

IvanaEscobar avatar Jun 04 '25 19:06 IvanaEscobar

I fixed few other issues in dynamics.F comments about the general algorithm description. These comments were added a long time ago (before thermodynamics.F was made out of dynamics.F) and it's better to fix the obvious mistake (sign, time-level, ...) even if they only describe the synchronous time-stepping (and not the staggered time-stepping).

jm-c avatar Jun 15 '25 14:06 jm-c

From my side, this PR is ready to be merged and could do this soon unless someone wants to add something. @IvanaEscobar do you agree ?

jm-c avatar Jun 25 '25 19:06 jm-c

@jm-c agree!

IvanaEscobar avatar Jun 25 '25 23:06 IvanaEscobar

@IvanaEscobar Thanks for cleaning these typos. Will merge this PR later today.

jm-c avatar Jun 26 '25 12:06 jm-c