mdanalysis icon indicating copy to clipboard operation
mdanalysis copied to clipboard

Implementation of SugarSelection

Open talagayev opened this issue 1 year ago • 3 comments

Fixes #4563

Changes made in this Pull Request:

  • Creation of the SugarSelection class that allows the selection of sugars through the access of known PDB, CHARMM and GLYCAM abbreviations
  • Addition of GLYCAM and SUGAR_PDB files in MDAnalysisTest.data
  • Addition of test_sugar_glycam_selection() and test_sugar_pdb_selection in test_atomselections.py

Currently I used the following abbreviations:

https://glycam.org/docs/othertoolsservice/2016/06/09/3d-snfg-list-of-residue-names/index.html

In addition of using the GLYCAM Webserver to obtain the known Sugar abbreviations and also included the aglycans that I obtained from the GLYCAM Weberserver.

The Pytest Files were retrieved from RCSB-PDB and the GLYCAM-Webserver:

https://glycam.org/

PR Checklist

  • [x] Tests?
  • [x] Docs?
  • [x] CHANGELOG updated?
  • [x] Issue raised/referenced?

Developers certificate of origin


📚 Documentation preview 📚: https://mdanalysis--4790.org.readthedocs.build/en/4790/

talagayev avatar Nov 14 '24 19:11 talagayev

Hello @talagayev! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2025-01-11 17:54:06 UTC

pep8speaks avatar Nov 14 '24 19:11 pep8speaks

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.64%. Comparing base (bdfb2c9) to head (cf29e91).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4790      +/-   ##
===========================================
- Coverage    93.66%   93.64%   -0.03%     
===========================================
  Files          177      189      +12     
  Lines        21795    22869    +1074     
  Branches      3067     3067              
===========================================
+ Hits         20414    21415    +1001     
- Misses         929     1002      +73     
  Partials       452      452              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Nov 14 '24 19:11 codecov[bot]

@hmacdope I will ping you here since you were one of the participants in the discussion that initiated the Issue that this PR is covering.

The main problem that I see currently, would be that the GLYCAM Abbreviations for the sugars due to the combinations have quite a lot of different names/abbreviations.

Some of them could lead to tricky cases, with the Allose Nomenclature having RNA as one of the abbreviations.

I checked the RCSB-PDB and found only one case, where a unique ligand was called RNA, but still could be dangerous if the users call something "RNA" in their files.

As for the coverage, while looking at the PDBs in RCSB-PDB it covers NAG, GLC etc., which would be convenient if somebody wants to select those in the PDB Files, but does not cover for example Glycerol, which makes sense since it is not a sugar, but is quite common in crystal structures among those sugars as NAG, GLC. Does it make sense to have a selection that would somehow covers both cases of Glycerol and similar compounds together with sugars?

talagayev avatar Nov 15 '24 23:11 talagayev