mdanalysis icon indicating copy to clipboard operation
mdanalysis copied to clipboard

Remove default parallelizable parameter in NoJump transformation

Open marinegor opened this issue 1 year ago • 3 comments

Fixes #4259

Changes made in this Pull Request:

  • remove parallelizable argument of NoJump transformation to avoid accidentally passing parallelizable=True

PR Checklist

  • [x] Tests?
  • [x] Docs?
  • [x] CHANGELOG updated?
  • [x] Issue raised/referenced?

Developers certificate of origin


📚 Documentation preview 📚: https://mdanalysis--4604.org.readthedocs.build/en/4604/

marinegor avatar May 22 '24 18:05 marinegor

Linter Bot Results:

Hi @marinegor! Thanks for making this PR. We linted your code and found the following:

There are currently no issues detected! 🎉

github-actions[bot] avatar May 22 '24 18:05 github-actions[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.45%. Comparing base (0f04e3e) to head (bf8843e). Report is 15 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4604      +/-   ##
===========================================
- Coverage    93.64%   93.45%   -0.20%     
===========================================
  Files          168      180      +12     
  Lines        21254    22333    +1079     
  Branches      3918     3619     -299     
===========================================
+ Hits         19904    20871     +967     
- Misses         892     1000     +108     
- Partials       458      462       +4     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 22 '24 19:05 codecov[bot]

Hello @marinegor! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2024-05-23 23:23:42 UTC

pep8speaks avatar May 22 '24 19:05 pep8speaks

oops...

Will merge when tests are ✅

orbeckst avatar May 23 '24 23:05 orbeckst