mdanalysis icon indicating copy to clipboard operation
mdanalysis copied to clipboard

Generalize continuous check in chain trajectory

Open jaclark5 opened this issue 3 years ago • 0 comments

Fixes #3546

Changes made in this Pull Request:

  • Added a CONCEPT for how to fix this issue with a base.ReaderBase method.

Note that the overwritten method in the LAMMPS reader was a solution that was integrated into my personal working version with very ugly if statements. I think a solution like this will keep things clean.

The tests fail and I don't know why, I could use some input.

PR Checklist

  • [ ] Tests?
  • [ ] Docs?
  • [ ] CHANGELOG updated?
  • [X] Issue raised/referenced?

jaclark5 avatar Sep 22 '22 17:09 jaclark5