Minecraft-Console-Client icon indicating copy to clipboard operation
Minecraft-Console-Client copied to clipboard

Allow newer SSL/TLS protocol versions

Open Daenges opened this issue 3 years ago • 8 comments

Fixes this issue.

Daenges avatar Aug 20 '22 11:08 Daenges

Would you mind adding a check so that the fix is only applied when launching the script using Mono?

ORelio avatar Aug 20 '22 16:08 ORelio

This works! - Question though, is it possible to have it relay messages only if there is a word match? Like, messages without a sender, such as custom messages from the server?

Like, customchatdetection but only if a certain word or phrase is included

madeline0706 avatar Aug 20 '22 17:08 madeline0706

@ORelio the error appeared on a Windows 10 machine. There was no mono installed.

Daenges avatar Aug 20 '22 17:08 Daenges

@ORelio the error appeared on a Windows 10 machine. There was no mono installed.

Since .NET 5.0/6.0 port, mono is no longer required, neither it works.

milutinke avatar Aug 20 '22 17:08 milutinke

@milutinke I tried to execute this script on the most recent build and it failed to compile. To verify this issue I downloaded an older build. So they might be using the 4.8 Framework version.

Daenges avatar Aug 20 '22 17:08 Daenges

Like, customchatdetection but only if a certain word or phrase is included

@haventhadadonutyet You can try to work with the ping system, so you actually get notified if the message contains a certain phrase. Or you try around with Chatformats and regular expressions to find messages with certain phrases.

Daenges avatar Aug 20 '22 17:08 Daenges

@ORelio the error appeared on a Windows 10 machine. There was no mono installed.

Since .NET 5.0/6.0 port, mono is no longer required, neither it works.

Oh, OK. This is weird because on .NET 5+ you should not need to manually set the TLS protocols like in .NET 4 Maybe the issue is related to this hotfix here that is likely no longer required: https://github.com/MCCTeam/Minecraft-Console-Client/blob/bb4c13168beaefb278d21140f3ae56ef788b8b00/MinecraftClient/Protocol/ProxiedWebRequest.cs#L127

ORelio avatar Aug 21 '22 19:08 ORelio

@ORelio as I mentioned here it is very likely that they didn't use the new .NET build, as the script is not working in it.

Daenges avatar Aug 21 '22 19:08 Daenges

@ORelio as I mentioned here it is very likely that they didn't use the new .NET build, as the script is not working in it.

OK so this is a fix for use with legacy builds. Okay, merging the PR.

ORelio avatar Sep 03 '22 13:09 ORelio