Node icon indicating copy to clipboard operation
Node copied to clipboard

GH-598: changes driven from discoveries the debugging gave us

Open bertllll opened this issue 3 months ago • 0 comments

[!NOTE] Adds accounting debug stats and message ID utilities, refactors pending-payables scanner and log wording, and updates address/test helpers.

  • Logging/Debugging:
    • Introduce logging_utils with accounting_msgs_debug (aggregate per-address debits over a window) and msg_id_generator.
    • Wire into Accountant (logging_utils, DEFAULT_ACCOUNTING_MSG_LOG_WINDOW, debug containers); msg_id() now uses new generator.
  • Accountant:
    • record_service_provided/consumed return u128; debug-posting collection for Report* handlers.
    • Improved trace/info wording for pending-payables reruns.
  • PendingPayableScanner:
    • Split into start_scan.rs and finish_scan.rs.
    • Rename caches/wording from "suspected" to "supposed"; log "Collected … supposed failures".
    • Simplify harvesting/merging APIs (use vectors, no Option), and tidy emptiness checks.
  • Tests/Strings:
    • Update expectations across tests and multinode integration to new log messages and behaviors.
    • Remove old MessageIdGenerator from sub_lib; add tests for new generator.
  • Utils:
    • Change blockchain::test_utils::make_address layout; adjust expected addresses in tests accordingly.

Written by Cursor Bugbot for commit e8dc24405102237831e1bd6cbced6f15a17b0ca9. This will update automatically on new commits. Configure here.

bertllll avatar Nov 04 '25 03:11 bertllll