Node icon indicating copy to clipboard operation
Node copied to clipboard

Gh 685 review2

Open czarte opened this issue 4 months ago • 0 comments

[!NOTE] Clarifies blockchain service URL help text and error messaging, fixes a misattributed configurator error, and updates tests to no longer pass --blockchain-service-url where unnecessary.

  • CLI/Help:
    • Update BLOCKCHAIN_SERVICE_HELP with <api-key> placeholders, improved grammar, and explicit --chain base-mainnet guidance.
  • Error handling:
    • Change required-arg message to singular phrasing; fix into_configurator_error target from gas-price to blockchain-service-url.
  • Unit/Integration Tests:
    • Adjust expectations for updated help/error strings.
    • Add helper to validate exceptions suppressing blockchain URL requirement.
    • Remove --blockchain-service-url from many MASQNode::start_* calls; minor arg tweaks (e.g., chain identifier from DEFAULT_CHAIN).

Written by Cursor Bugbot for commit 317243fc4365264272706362002f108b2c354f17. This will update automatically on new commits. Configure here.

czarte avatar Sep 30 '25 09:09 czarte