Node icon indicating copy to clipboard operation
Node copied to clipboard

GH-605: Review 3

Open utkarshg6 opened this issue 4 months ago • 0 comments

[!NOTE] Migrates payables to explicit SentTx/FailedTx with receipt-driven status (TxReceiptsMessage), drops pending-payable DAO/table, introduces detailed scan types/scheduling, and updates APIs, serialization, defaults, and tests.

  • Accounting/Scanning:
    • Replace fingerprint-based pending-payable flow with SentTx/FailedTx records and receipt-driven status via TxReceiptsMessage and StatusReadFromReceiptCheck/TxBlock.
    • Remove PendingPayableDao usage; add caches and interpreter for tx receipts; update comparisons/ordering and logging.
    • Introduce DetailedScanType, Retry hints, and ScanReschedulingAfterEarlyStop naming; adjust scheduling APIs.
    • Rename TxSentTx and fields to amount_minor/gas_price_minor; propagate across builders, SQL, and assertions.
    • Enhance ValidationStatus with PreviousAttempts (custom serde/ordering) and error-kind restructuring.
  • Blockchain Bridge/Interface:
    • Switch receipt processing to map of TxHashByTable → TxReceiptResult; add RegisterNewPendingPayables.
    • Replace legacy receipt/status types; adapt agent submission error to structured form.
  • Database:
    • Drop pending_payable table; migrations updated; config defaults now chain-aware for ScanIntervals.
  • CLI/Config:
    • Validate payment thresholds and scan-interval relationships; compute scan-interval defaults per chain.
  • Tests:
    • Broad updates to reflect new types, messages, scheduling, and logging; new mocks for serializer and caches.

Written by Cursor Bugbot for commit 02d98fb03109c568c592d5777cb6a73faf8038b0. This will update automatically on new commits. Configure here.

utkarshg6 avatar Sep 20 '25 06:09 utkarshg6