Node
Node copied to clipboard
GH-605: Review 3
[!NOTE] Migrates payables to explicit
SentTx/FailedTxwith receipt-driven status (TxReceiptsMessage), drops pending-payable DAO/table, introduces detailed scan types/scheduling, and updates APIs, serialization, defaults, and tests.
- Accounting/Scanning:
- Replace fingerprint-based pending-payable flow with
SentTx/FailedTxrecords and receipt-driven status viaTxReceiptsMessageandStatusReadFromReceiptCheck/TxBlock.- Remove
PendingPayableDaousage; add caches and interpreter for tx receipts; update comparisons/ordering and logging.- Introduce
DetailedScanType,Retryhints, andScanReschedulingAfterEarlyStopnaming; adjust scheduling APIs.- Rename
Tx→SentTxand fields toamount_minor/gas_price_minor; propagate across builders, SQL, and assertions.- Enhance
ValidationStatuswithPreviousAttempts(custom serde/ordering) and error-kind restructuring.- Blockchain Bridge/Interface:
- Switch receipt processing to map of
TxHashByTable → TxReceiptResult; addRegisterNewPendingPayables.- Replace legacy receipt/status types; adapt agent submission error to structured form.
- Database:
- Drop
pending_payabletable; migrations updated; config defaults now chain-aware forScanIntervals.- CLI/Config:
- Validate payment thresholds and scan-interval relationships; compute scan-interval defaults per chain.
- Tests:
- Broad updates to reflect new types, messages, scheduling, and logging; new mocks for serializer and caches.
Written by Cursor Bugbot for commit 02d98fb03109c568c592d5777cb6a73faf8038b0. This will update automatically on new commits. Configure here.