XPrivacy icon indicating copy to clipboard operation
XPrivacy copied to clipboard

[enhancement] Remove whitelist for accounts / applications / contacts

Open Gitoffthelawn opened this issue 10 years ago • 8 comments

When the user creates a whitelist for accounts/applications/contacts for specific apps, there is no way to completely remove the whitelist without clearing all XPrivacy settings for those apps. This causes XPrivacy to get slower and use more memory over time because the applications and contacts whitelists typically add a massive amount of data to the internal XPrivacy settings. Also, it causes issues when new accounts/applications/contacts are added (even when All was selected in the whitelists).

Recommendation: Allow users to delete accounts/application/contacts whitelists for specific apps when they no longer need them.

Gitoffthelawn avatar Dec 11 '15 21:12 Gitoffthelawn

XPrivacy will by design not get slower when there are a lot of accounts, contacts and/or applications selected.

M66B avatar Dec 12 '15 07:12 M66B

When XPrivacy loads, it displays a progress bar. Displaying the progress bar can take anywhere from 1 second to 80 seconds (or longer, but 80 is the longest I've timed), depending on the speed of the device and how many rules are in place. When contacts are whitelisted/blacklisted, thousands of additional rules are often created (as seen in an export). Does this impact the time it takes for XPrivacy to get through that progress bar?

What about memory usage?

Also, even when All is selected, when new contacts are created, they will not be added to the whitelist. The only way to get rid of that whitelist is to delete all XPrivacy settings for the app.

Gitoffthelawn avatar Dec 12 '15 07:12 Gitoffthelawn

The progress bar reflects mainly how much time the contacts provider takes to deliver the contacts.

XPrivacy will not slow down when there are many contact restrictions in place.

M66B avatar Dec 12 '15 07:12 M66B

Interesting. So the XPrivacy progress bar is just the time it takes to load contacts? If so, would it be possible to only load contacts if the user tries to use the contacts whitelist. Although I love XPrivacy, waiting for that progress bar gets tiresome and interferes with workflow.

Gitoffthelawn avatar Dec 12 '15 07:12 Gitoffthelawn

I think we had a misunderstanding, I was referring to the contacts whitelist loading.

And no, the loading you mean cannot be made faster. This has been asked often on XDA and explained accordingly. Basically there are just a lot of restrictions/settings to check for each application (about 500) multiplied by the number of applications it will just take significant time.

M66B avatar Dec 12 '15 07:12 M66B

Okay, yes, that was my understanding. I've taken a close look at the XPrivacy exports. Once you study them as I have, the progress bar certainly makes sense.

So I think the enhancement request is based on memory usage, export file size, and the ability to add new contacts without them being automatically blacklisted. Having the ability to delete the whitelist will resolve those 3 issues.

Gitoffthelawn avatar Dec 12 '15 07:12 Gitoffthelawn

Hmm if new contacts aren't automatically blacklisted, that seems like an important issue. I support this suggestion.

Cerberus-tm avatar Dec 14 '15 23:12 Cerberus-tm

Contacts are whitelisted

M66B avatar Dec 15 '15 00:12 M66B