Lychee icon indicating copy to clipboard operation
Lychee copied to clipboard

Additional 'landing_background' config options

Open MikeTheTux opened this issue 4 years ago • 3 comments

landing_background should provide the following additional config options:

  • random (public) image
  • cover photo of random (public) album
  • latest (public) image
  • cover photo of latest (public) album

MikeTheTux avatar Sep 26 '21 07:09 MikeTheTux

I can have a look at this one. Anything in the refactoring I should take into consideration? @ildyria @nagmat84

scottlimmer avatar Oct 13 '21 10:10 scottlimmer

I guess you want to start your development branch on top of master? The main differences between the re-factored architecture of the albums and the current master branch is the way how albums and pictures are queried.

You basically have two options:

a) Start on top of the branch with the re-factored architecture. That would help me because then I won't need to merge your changes into the branch with the re-factored architecture later. However you should be prepared that your PR might take some while until it gets integrated into master depending on how long it takes to merge the re-factored architecture.

b) Start an top of the master branch and document the parts which query the DB very well to ease later re-factoring.

If I was you I would take option b), if I was me (oh, wait I am me), then I would take option a), so that my future-me has less to do.

Despite from that there is nothing in particular.

nagmat84 avatar Oct 13 '21 19:10 nagmat84

I'll start with the master branch as base and we can get the functionality right. Can look at merging to the refactored arch after that.

scottlimmer avatar Oct 17 '21 09:10 scottlimmer