Lychee-Docker icon indicating copy to clipboard operation
Lychee-Docker copied to clipboard

Add support for docker secrets

Open berndderidder opened this issue 5 years ago • 1 comments

It would be great to have support for docker secrets.

Looking at the available environment variables I think these should be added:

  • DB_PASSWORD_FILE
  • REDIS_PASSWORD_FILE
  • MAIL_PASSWORD_FILE
  • PUSHER_APP_KEY_FILE
  • PUSHER_APP_SECRET_FILE

I had a look at inject.sh and my initial thought was like this:

if [ "$DB_PASSWORD_FILE" != '' ]; then
  value=$(<$DB_PASSWORD_FILE)
  sed -i "s|DB_PASSWORD=.*|DB_PASSWORD=${value}|i" /conf/.env
fi

I think this should be it?

berndderidder avatar May 25 '20 21:05 berndderidder

I would also welcome this! I dug around to find an alternative but couldn't find one :( I am happy to create a PR for this one.

Any thoughts on the suggestion from @berndderidder ? I also think that would work.

felin-arch avatar Nov 29 '20 22:11 felin-arch

Are there any plans to implement this enhancement?

mingan666 avatar Mar 28 '23 06:03 mingan666

#149

d7415 avatar Sep 10 '23 21:09 d7415