lime-elements icon indicating copy to clipboard operation
lime-elements copied to clipboard

Text editor: switching a list between ordered an unordered does not work

Open eketorp opened this issue 1 year ago • 3 comments

Current behavior

It does not work to turn an unordered list into an ordered

https://github.com/user-attachments/assets/639d11b2-2dbe-4654-992b-fbdc18944456

Steps to reproduce the behavior:

  1. create an unordered list
  2. highlight the items
  3. click "ordered list"
  4. nothing happens (first error)
  5. remove each bullet
  6. highlight the items
  7. click "ordered list"
  8. items are all considered "first item" (second error)

Expected behavior

You should be able to do this:

https://github.com/user-attachments/assets/88519ac6-496d-49a7-8617-4cdb2d6f942d

Environment

versions/37.70.1/#/component/limel-text-editor/

eketorp avatar Nov 22 '24 09:11 eketorp

Related to https://github.com/Lundalogik/lime-elements/issues/3178

eketorp avatar Nov 22 '24 09:11 eketorp

Any reason for this being on-hold @john-traas?

oh, you are assigned to this, are you working on it?

FredrikWallstrom avatar Nov 05 '25 07:11 FredrikWallstrom

Ah yes. Thanks for the question @FredrikWallstrom Handling lists, especially nested lists, seems really tricky and a bit complex. While working on this I found that I wanted to be able to test the functionality I was trying to implement while I was developing it, so I put this on hold as I began working on a test suite for the text editor.

Last cooldown I started working through and slowly resolving the mountain of AI review comments on this PR https://github.com/Lundalogik/lime-elements/pull/3508

The PR to actually handle list toggling/functionality became a bit of a behemoth as I built it on top of the one with the test suite https://github.com/Lundalogik/lime-elements/pull/3431

I put them both on hold just because other issues have been more prioritised.

john-traas avatar Nov 05 '25 08:11 john-traas