lime-elements icon indicating copy to clipboard operation
lime-elements copied to clipboard

Code block button in text editor does nothing

Open eketorp opened this issue 1 year ago • 7 comments

Current behavior

https://github.com/user-attachments/assets/041735d5-e3b1-484f-b7fb-a620f9a59842

Expected behavior

Should do something.

Or simply remove it. The need for code blocks in CRM is least to say low.

Environment

  • lime-elements version: 37.60.1

eketorp avatar Sep 18 '24 11:09 eketorp

is it still the case @eketorp ?

Kiarokh avatar Sep 26 '24 08:09 Kiarokh

Yes. As soon as I have a line break.

eketorp avatar Sep 26 '24 14:09 eketorp

interesting. it seems it generally has problems handling line breaks. I saw your other issue https://github.com/Lundalogik/lime-elements/issues/3178 when pressing the "list" button, it would only add the first line as the first list item.

@john-traas FYI

Kiarokh avatar Sep 27 '24 09:09 Kiarokh

@Kiarokh @eketorp

I'm looking at prioritising some of the peripheral issues related to the text-editor.

Do we feel there's enough of a use case or demand within our CRM for the code block command? Should we remove it?

I feel like we could add it back if it became the case that there's a demand for it. At that time we could solve this issue properly.

john-traas avatar May 08 '25 12:05 john-traas

This is the usage by app over the last 30 days. I picked a donut chart because everyone knows that donut charts are the best.

Image

There is some usage but I am fine removing it before more people start using it and get annoyed about things that do not work properly.

eketorp avatar May 08 '25 13:05 eketorp

I know I've used it many times in Sublime and Product Lime. And we don't sell the CRM to a particular user group. "Anyone" can be a current or potential user of the CRM. So removing something like this isn't something I'd support. I think we should try to make these things work as they do in Prosemirror. Of if current implementation works, but it's a bit buggy, we can leave it like this. It does still solve user needs, even if the experience is buggy.

Kiarokh avatar May 12 '25 09:05 Kiarokh

Thanks for the valuable feedback! A fix is in the works. I've been using time during cooldowns to make progress on non-cycle related Text-Editor functionality.

I'll keep this as an issue we want to fix.

john-traas avatar May 12 '25 09:05 john-traas