lime-elements icon indicating copy to clipboard operation
lime-elements copied to clipboard

refactor(chip-set): correctly use MDC's HTML & classes

Open Kiarokh opened this issue 2 years ago • 2 comments

required for https://github.com/Lundalogik/crm-feature/issues/2723

We're inheriting styles from MDC, but since our HTML structure was not exactly similar to the one from MDC's input-field, and some classes were missing, then we had to make special styles to override what was coming from MDC, or to compensate for what was missing, due to missing classes.

⚠️ to the reviewer: just make sure that the chipset (and picker) visually looks alright. It was impossible to break down this commit into several meaningful and easier to follow commits.

Review:

  • [ ] Commits are atomic
  • [ ] Commits have the correct type for the changes made
  • [ ] Commits with breaking changes are marked as such

Browsers tested:

(Check any that applies, it's ok to leave boxes unchecked if testing something didn't seem relevant.)

Windows:

  • [ ] Chrome
  • [ ] Edge
  • [ ] Firefox

Linux:

  • [ ] Chrome
  • [ ] Firefox

macOS:

  • [ ] Chrome
  • [ ] Firefox
  • [ ] Safari

Mobile:

  • [ ] Chrome on Android
  • [ ] iOS

Kiarokh avatar Jan 04 '24 10:01 Kiarokh

Documentation has been published to https://lundalogik.github.io/lime-elements/versions/PR-2683/

github-actions[bot] avatar Jan 04 '24 10:01 github-actions[bot]

we need to come back to this after we have:

  1. used the new limel-chip in the chip-set
  2. refactored limel-input-field so that it is not depending on MDC

Kiarokh avatar Feb 07 '24 15:02 Kiarokh