Lundalogik
Add password field
Description
Solved #1865
I added a field for entering a password, which can display the password after clicking the button. It can also validate the password so that it is as safe as possible.
Browsers tested:
Windows:
- [x] Chrome
- [ ] Edge
- [ ] Firefox
Linux:
- [ ] Chrome
- [ ] Firefox
macOS:
- [ ] Chrome
- [ ] Firefox
- [ ] Safari
Mobile:
- [ ] Chrome on Android
- [ ] iOS
Hi @DominikGajdos! Thank you for this! Sorry you've had to wait so long for any response. There's been a lot to do lately 😅
I just wanted to ensure you you've not been forgotten, and say that I've just started to have a look at this now 👍 🙂
@anderssonjohan The SonarCloud scan fails on this PR because it comes from an external fork, so the SonarCloud token isn't provided to the workflow, to protect it from being stolen by a forked repo. I can disable that workflow for PRs from external forks, but it seems like it would be particularly appropriate to run these scans on precisely this kind of PRs… 😕
Is there anything that could potentially be done?
@anderssonjohan The SonarCloud scan fails on this PR because it comes from an external fork, so the SonarCloud token isn't provided to the workflow, to protect it from being stolen by a forked repo. I can disable that workflow for PRs from external forks, but it seems like it would be particularly appropriate to run these scans on precisely this kind of PRs… 😕
Is there anything that could potentially be done?
Oh noes, that's so unfortunate. It seems there's no true support for this but there are workarounds that are a bit hacky / requires a bit of work: https://community.sonarsource.com/t/how-to-use-sonarcloud-with-a-forked-repository-on-github/7363/32
