lime-elements icon indicating copy to clipboard operation
lime-elements copied to clipboard

fix(dock-button): give back focus when menu is closed

Open vicgeralds opened this issue 3 years ago • 1 comments

Almost fixes https://github.com/Lundalogik/lime-elements/pull/1820#discussion_r978358996

fix: https://github.com/Lundalogik/crm-feature/issues/2989

The tricky part is we don't know here how the menu was closed. If the user navigated to an item in the menu, we don't expect focus back.

Review:

  • [ ] Commits are atomic
  • [ ] Commits have the correct type for the changes made
  • [ ] Commits with breaking changes are marked as such

Browsers tested:

(Check any that applies, it's ok to leave boxes unchecked if testing something didn't seem relevant.)

Windows:

  • [ ] Chrome
  • [ ] Edge
  • [ ] Firefox

Linux:

  • [ ] Chrome
  • [ ] Firefox

macOS:

  • [ ] Chrome
  • [ ] Firefox
  • [ ] Safari

Mobile:

  • [ ] Chrome on Android
  • [ ] iOS

vicgeralds avatar Sep 28 '22 15:09 vicgeralds

Documentation has been published to https://lundalogik.github.io/lime-elements/versions/PR-1843/

github-actions[bot] avatar Sep 28 '22 15:09 github-actions[bot]