darkplus.nvim icon indicating copy to clipboard operation
darkplus.nvim copied to clipboard

Fix changing colors

Open gepbird opened this issue 2 years ago • 1 comments

Before this PR, comments ~~and keywords~~ are changing colors when you load to file:

https://github.com/LunarVim/darkplus.nvim/assets/29818440/8b27cec1-548c-45d5-8026-979979756cda

This PR makes comments always green without italic (just like in vscode) ~~and treats builtin functions as functions so they are yellow~~.

Unfortunately variables that are used as functions (like hl in the video) are still changing colors. I assume neovim thinks it's a function because it has a ( next to it so it gives the yellow highlight, then treesitter says it's just a variable and changes it back to light blue. I believe if lua_ls recognized it being a function it wouldn't change colors and stay yellow.

darkplus-pr

Edit: removed "fix" for functions as it has been already implemented at https://github.com/LunarVim/darkplus.nvim/commit/d04d43da4b204a9911fd301754d0868b0dbfbde1#diff-f6396e3ad2299402e37c1ffe426fc126f7c6bfc3ef40b49eed8ed657447a1442L127.

gepbird avatar Jun 24 '23 13:06 gepbird

I resolved the merge conflicts, feel free to take a look at this PR

gepbird avatar Jan 02 '24 00:01 gepbird