LukeMathWalker
Add support for Rust 1.88 in cargo-chef latest Docker image
Hi there,
I'm not able to run my rust 1.88 project with the following image:
lukemathwalker/cargo-chef:latest-rust-latest
Which fails with:
error: rustc 1.87.0 is not supported by the following packages:
I had to temporarily use the rust image as as workaround to make it work:
FROM rust:1 AS chef
RUN cargo install cargo-chef
Thanks!
It looks like the GitHub Action to publish the Docker image with Rust 1.88 has already run, but the Docker Hub page says it was last updated 5 days ago.
https://github.com/LukeMathWalker/cargo-chef/actions/runs/15952975743 https://hub.docker.com/r/lukemathwalker/cargo-chef
Apparently, duplicate check gave false positive: https://github.com/LukeMathWalker/cargo-chef/actions/runs/15952975743/job/44995462236
This should probably fix it: https://github.com/LukeMathWalker/cargo-chef/pull/311
@LukeMathWalker can you check please, chef is not cooking in 1.88 :)
I have published a new version of cargo-chef (0.1.72) to solve the issue.
I tried #311, but the root cause seems to be subtler: the duplication check won't work on "shorthand" tags (e.g. see this one) because there will always be another tag upstream with the same name. We need something more sophisticated.
Hey @LukeMathWalker, first of all, thanks a lot for your work on this sir 🙇
It seems like the same situation happens for 1.89 version, we manually bumped latest-rust-1 to a specific 1.89 version as latest-rust-1 points to 1.88. Is that something that you think could be addressed? I'm also happy to dive deeper into the cause of this unless you already know well how to solve that one 🫡
The root cause is the one described in https://github.com/LukeMathWalker/cargo-chef/issues/310#issuecomment-3021889498. We need a way to annotate which chef and Rust version were used in each tag, and trigger a rebuild+repush based on the latest state of both. I don't have bandwidth to put together a script to do it, but happy to review one if you do!