Luca Prete comments

Results 46 comments of


                                            Luca Prete

Change advertised_ip_ranges fields in google_compute_router_peer and google_compute_router resources to Sets

> I'll leave review to @roaks3. > > If this PR addresses ordering diffs on this field by converting it to a Set in 6.0.0 then this PR will also...

Change advertised_ip_ranges fields in google_compute_router_peer and google_compute_router resources to Sets

@SarahFrench @roaks3 I see in my local tests that something is failing in the generated router code: ``` make testacc TEST=./google-beta/services/compute TESTARGS='-run= TestAccComputeRouter_routerBasicExample' ==> Checking that code complies with gofmt...

Change advertised_ip_ranges fields in google_compute_router_peer and google_compute_router resources to Sets

> Follow-up note: this should be changed to point to the feature branch since it is a breaking change (see https://googlecloudplatform.github.io/magic-modules/develop/breaking-changes/make-a-breaking-change/) Thanks @roaks3 I just rebased, hopefully on the correct...

'gh pr create' fails if skipping pushing with "GraphQL error: Head sha can't be blank, Base sha can't be blank, No commits between master and <branch>, Head ref must be a branch"

+1 same issue

Add support for secure tags in hierarchical firewall policies

yes! Il giorno mar 17 giu 2025 alle ore 21:10 Zhenhua Li < ***@***.***> ha scritto: > *zli82016* left a comment (GoogleCloudPlatform/magic-modules#14021) > > > @LucaPrete , is this PR...

Add support for secure tags in hierarchical firewall policies

> @LucaPrete, is this PR ready for review? @zli82016 sorry I don't know if you have been notified from my previous message but yes. From my perspective it's ready for...