Please clarify that you need a local installation of git for the addons to work

[another-m00]

How are you using the lua-language-server?

Visual Studio Code Extension (sumneko.lua)

Which OS are you using?

Windows

What is the issue affecting?

Libraries

Expected Behaviour

I expected the extension to work out of the box or have a a set up guide.

Actual Behaviour

Currently on windows the addon manager throws an uncaught spawn git ENOENT without any details. I had to go back through the logs to figure it out, that I need a local git installation.

Reproduction steps

1. Install Visual Studio on a fresh windows machine
2. Install the lua lls extension
3. Try to open the addon manager
4. Get the spawn git ENOENT error with the trimmed logs

Additional Notes

It would be enough to include a section in the documentation, or handle this error.

Log File

I'm including the extension log as this is a dependency issue with simple-git

exthost.log

The relevant line is line 322.

[carsakiller]

Hello👋

There should already be a check and warning in place when starting the extension without Git installed: https://github.com/LuaLS/vscode-lua/blob/5fa0fbb154298035fb78b0d142ac8feaf68fc171/client/src/addon_manager/registration.ts#L64

Did you not receive this warning?

[another-m00]

Hello, No, I don't remember to see any error messages like that when I started up the addon manager. The addon just crashed with the ENOENT, and the addon session log only contained a single line saying that logging is started. There was a log file by simple git that stated that it cannot find the exe file though.

Is it possible that's happening because I installed a different git already? (Github desktop)

I'll tell more accurate information when I'm back home in a few hours.