lua-language-server icon indicating copy to clipboard operation
lua-language-server copied to clipboard

`workspace.library` does not honor `workspace.ignoreDir`

Open nyarthan opened this issue 1 year ago • 2 comments

How are you using the lua-language-server?

NeoVim

Which OS are you using?

MacOS

What is the issue affecting?

Other

Expected Behaviour

I think it would make sense to also honor the workspace.ignoreDir setting when including libraries via workspace.library.

My use case is probably rather niche but it pretty much breaks the indexing: I have a local library that I want to include via workspace.library, at the root of the library is a directory .direnv which includes symlinks to nix derivations (which intern include more than 100000 lua files)

So I would expect a configuration like

"workspace": {
  "ignoreDir": [".direnv"],
  "library": "path-to-lib"
}

to not index files inside <path-to-lib>/.direnv

Actual Behaviour

Every file inside the library path is indexed

Reproduction steps

Follow example from above

Additional Notes

No response

Log File

No response

nyarthan avatar Nov 07 '24 19:11 nyarthan

I think this is helpful for adding typechecking to previously untyped repos. in my use case, it would be ignoring a test directory

PeterCardenas avatar Jun 30 '25 05:06 PeterCardenas

This should work 😕

Here's an another discussion: https://github.com/LuaLS/lua-language-server/discussions/3213#discussion-8504492, where OP wants to separate the ignoreDir settings used when filtering library paths and project paths. OP wants to filter a same named directory in library paths only, but not in project path.

tomlau10 avatar Jun 30 '25 14:06 tomlau10