lua-language-server icon indicating copy to clipboard operation
lua-language-server copied to clipboard

can't auto detect love2d project (3.71 is OK, 3.7.2 and 3.7.3 are broken).

Open zhengying opened this issue 2 years ago • 3 comments

How are you using the lua-language-server?

Visual Studio Code Extension (sumneko.lua)

Which OS are you using?

MacOS 13.4 intel

What is the issue affecting?

Can't auto detect love2d project, no popup for write configure for love2d project. (NOTICE: 3.71 is OK, 3.7.2 and 3.7.3 are broken)

Expected Behaviour

this popup should be popup when the Lua file contains love. load or love.update ..., but currently version no popup shows.

Screenshot 2023-11-18 at 11 57 07

Actual Behaviour

Screenshot 2023-11-18 at 11 57 07 this popup should show when detecting the love2d project

Reproduction steps

t1.zip

  1. use vscode to open this folder
  2. open main.lua
  3. should popup the configure popup(see image). Screenshot 2023-11-18 at 11 57 07

Additional Notes

3.71 is OK, 3.7.2 and 3.7.3 are broken

Log File

No response

zhengying avatar Nov 18 '23 04:11 zhengying

When the Lua.workspace.checkThirdParty": true configuration is added in the settings, it works. However, I didn't add this item before. I believe the default value was true before version 3.7.2, but it was changed in that version. However, I am unsure if this change was intentional.

zhengying avatar Nov 18 '23 12:11 zhengying

@9999years I haven't taken a good look, but I saw you were the implementor on #2354, is this an issue from the new behaviour?

carsakiller avatar Nov 20 '23 04:11 carsakiller

I've also found the auto-detection broken for my Factorio library with 3.7.2 and 3.7.3

justarandomgeek avatar Nov 28 '23 02:11 justarandomgeek