Brightness icon indicating copy to clipboard operation
Brightness copied to clipboard

App now gets display names from display EDID

Open Soggy-Pancake opened this issue 1 year ago • 4 comments

The app now sets the correct connection for xrandr in self.displays. self.displays now is a nested array contaning the connection and the monitor name (ex: ["dp-1", "monitor"]), which should solve #220.

I also fixed the imports as it would crash upon trying to import anything under brightness_controler_linux as the init.py had been moved to the same folder some time back.

Soggy-Pancake avatar Mar 22 '24 01:03 Soggy-Pancake

Hey! Thanks for the pull request and for addressing #220 !

Right now, I do not have a Linux machine to test this. @archisman-panigrahi , can you please help me by taking a look at it? Since the import statements changed a bit, your scripts to build packages might break, so I want your attention on this part!

LordAmit avatar Mar 27 '24 17:03 LordAmit

I just added a protection for when the display doesnt give EDID or the name cant be found for some reason. It will fall back to the connection name (ex. DP-0) if the name extraction fails for any reason.

Soggy-Pancake avatar Mar 27 '24 19:03 Soggy-Pancake

Sorry about the delay responding. I will review it this weekend.

your scripts to build packages might break, so I want your attention on this part!

The ddcutil version is not in PPA because I am yet to figure out how to package this new version.

archisman-panigrahi avatar Apr 02 '24 23:04 archisman-panigrahi

Wayland crashes have been fixed as I just managed to get wayland working yesterday. The original software brightness doesn't work on Wayland but ddc now will.

Soggy-Pancake avatar Sep 08 '24 03:09 Soggy-Pancake