LoRaMac-node icon indicating copy to clipboard operation
LoRaMac-node copied to clipboard

Invalid include directories in CMake

Open NovaNekmit opened this issue 3 years ago • 0 comments

While linting my project I noticed that the following CMake lines add paths to include, that do not actually exist:

https://github.com/Lora-net/LoRaMac-node/blob/master/src/system/CMakeLists.txt#L27 https://github.com/Lora-net/LoRaMac-node/blob/master/src/system/CMakeLists.txt#L34 Maybe an older path got forgotten here?

https://github.com/Lora-net/LoRaMac-node/blob/master/src/radio/CMakeLists.txt#L65 Here, maybe the loop variable R is supposed to be used here instead of RADIO (assuming the includes for the other radios are even needed, else just drop the loop).

NovaNekmit avatar Jul 21 '22 14:07 NovaNekmit