readfish
readfish copied to clipboard
DRAFT Feature/minknow6 compatibility
Highlights
Adds in compatibility for MinKNOW 6.
[!WARNING] Breaking for any version of
MinKNOW <= 6.0.0
It will not run against MinKNOW <= 6.0.0, instead logging a critical message, suggesting a downgrade and raising SystemExit.
Key Changes
- Updates the
ont-readuntil-apitov3.5.2, which removes any use of read number in the API. - Removes all use of
read_numberin readfish code, including the logging ofread_numberin the debug log. - Fixes the test to use the new
connected_basecaller_versionfor compatibility checking. - Includes a readfish logo in SVG, because I made one for my thesis.
- Pins minimum
ont-pybasecall-clientto 7.4.12
Todo before merging
**I suggest that we take this opportunity to drop Guppy support entirely. **
[!NOTE] We are still using read_number in some trackers, these will definitely stop working properly until they are updated to use
read_id
- [ ] Drop guppy.py
- [ ] Remove Guppy tests
- [ ] Remove guppy from documentation
- [ ] Remove
ont-pyguppy-client-libfrompyproject.toml - [ ] Update Trackers to use
read_idnotread_number - [ ] Add warning to README.md
Do we need to add dorado tests as well?
I've had a stab at addressing some of these issues in #feature/deprecate-guppy