readfish icon indicating copy to clipboard operation
readfish copied to clipboard

DRAFT Feature/minknow6 compatibility

Open Adoni5 opened this issue 1 year ago • 2 comments

Highlights

Adds in compatibility for MinKNOW 6.

[!WARNING] Breaking for any version of MinKNOW <= 6.0.0

It will not run against MinKNOW <= 6.0.0, instead logging a critical message, suggesting a downgrade and raising SystemExit.

Key Changes

  • Updates the ont-readuntil-api to v3.5.2, which removes any use of read number in the API.
  • Removes all use of read_number in readfish code, including the logging of read_number in the debug log.
  • Fixes the test to use the new connected_basecaller_version for compatibility checking.
  • Includes a readfish logo in SVG, because I made one for my thesis.
  • Pins minimum ont-pybasecall-client to 7.4.12

Todo before merging

**I suggest that we take this opportunity to drop Guppy support entirely. **

[!NOTE] We are still using read_number in some trackers, these will definitely stop working properly until they are updated to use read_id

  • [ ] Drop guppy.py
  • [ ] Remove Guppy tests
  • [ ] Remove guppy from documentation
  • [ ] Remove ont-pyguppy-client-lib from pyproject.toml
  • [ ] Update Trackers to use read_id not read_number
  • [ ] Add warning to README.md

Adoni5 avatar Jul 31 '24 16:07 Adoni5

Do we need to add dorado tests as well?

mattloose avatar Jul 31 '24 20:07 mattloose

I've had a stab at addressing some of these issues in #feature/deprecate-guppy

mattloose avatar Jul 31 '24 20:07 mattloose