readfish icon indicating copy to clipboard operation
readfish copied to clipboard

Names are confusing in the stats module

Open Adoni5 opened this issue 2 years ago • 0 comments

An idea but it would be nice to rename some of the counters and variables!

We have a lot of intermixing between actions and decisions going on.

Example:

    # Increment total actions count, Unblock, stop_receiving etc.
    self.actions[decision_name] += 1
    # increment count for this decision - single_off, single_on etc.
    self.decisions[kwargs.get("mode")] += 1

It would make more sense (IMO) to be updating self.decisions with decision_name and not mode.

Would be nice to work through these and standardise the names used in Counters

Adoni5 avatar Oct 12 '23 10:10 Adoni5