[BUG] create_basal_contact_orientations() no longer called in map2loop

[markjessell]

Describe your issue

create_basal_contact_orientations() no longer called in map2loop

Minimal reproducing code example

code as is doesn't call this function any more...

Error message

No response

[RoyThomsonMonash]

Hi Mark,

Going through the repo history the create_basal_contact_orientations function was never called as part of the project run function. The save_basal_contacts_orientations_csv function is instead called and it does the same thing.

Recently (as of map2loop2 version 1.3.5 - Feb 2023) interpolating basal contacts and their orientations was removed by default and is now managed by using "workflow['contact_dips'] = True" before the Project run function is called.

[markjessell]

Hi Roy, sorry my bad. I was trying to understand why so few contact orientations were being created even when decimations were set to zero. That question still remains.

From my failing memory, if decimations were set to zero, all contact nodes should spit out an orientations as well, but that does not seem to be the case?

Cheers

Mark

Mark Jessell Professor/ Western Australian Fellow Centre for Exploration Targeting/ SES * M006, Perth WA 6009 Australia T +61 8 6488 5803 * E @.***

---

From: Roy Thomson @.> Sent: Wednesday, September 13, 2023 7:34:36 AM To: Loop3D/map2loop-2 @.> Cc: Mark Jessell @.>; Author @.> Subject: Re: [Loop3D/map2loop-2] [BUG] create_basal_contact_orientations() no longer called in map2loop (Issue #108)

Hi Mark,

Going through the repo history the create_basal_contact_orientations function was never called as part of the project run function. The save_basal_contacts_orientations_csv function is instead called and it does the same thing.

Recently (as of map2loop2 version 1.3.5 - Feb 2023) interpolating basal contacts and their orientations was removed by default and is now managed by using "workflow['contact_dips'] = True" before the Project run function is called.

Reply to this email directly, view it on GitHubhttps://github.com/Loop3D/map2loop-2/issues/108#issuecomment-1716680565, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABUBSYAOE7NO4FNWTJCT23LX2DWQZANCNFSM6AAAAAA4RLLLSI. You are receiving this because you authored the thread.Message ID: @.***>