map2loop-2 icon indicating copy to clipboard operation
map2loop-2 copied to clipboard

[BUG] ignore_codes not taken into account in save_basal_contacts()

Open markjessell opened this issue 2 years ago • 1 comments

Describe your issue

I use the run_flag ignore_codes to ignore surficial geology, but as far as I can tell the basal contacts which are used to extract contact polylines for later use by map2loop don't reflect the run_flag ignore_codes.

As a result contacts between surficial polygons and real geology polygons are kept, resulting in 3D model weirdness.

Minimal reproducing code example

same code and data maroc dataset I sent wrt issue #100

Error message

No response

markjessell avatar May 03 '23 06:05 markjessell

Release 1.3.6 has refactored how the basal contacts are calculated, the ignore_codes parameter should have removed these units from basal contact calcs. Please check that this is fixed so I can close this issue

RoyThomsonMonash avatar May 29 '23 04:05 RoyThomsonMonash