Sunshine icon indicating copy to clipboard operation
Sunshine copied to clipboard

Add missing EGL extension for linux

Open brownj85 opened this issue 3 years ago • 3 comments

Description

Adds 'EGL_EXT_image_dma_buf_import_modifiers' to the list of required EGL extensions when initializing display. This extension is required to support the many of the parameters passed to eglCreateImage(). The parameters provided by the extension are listed here: https://registry.khronos.org/EGL/extensions/EXT/EGL_EXT_image_dma_buf_import_modifiers.txt

They are used in src/platform/linux/graphics.cpp.

Adding this extension fixes the EGL_BAD_ATTRIBUTE (00003004) error code from eglCreateImage(). It may also fix the EGL_BAD_ACCESS (00003002) error but I can't verify.

Issues Fixed or Closed

  • Fixes #48

Type of Change

  • [x] Bug fix (non-breaking change which fixes an issue)

Checklist

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have added or updated the docstring/documentation-blocks for new or existing methods/components

brownj85 avatar Aug 26 '22 22:08 brownj85

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Aug 26 '22 22:08 CLAassistant

Your PR was set to master, PRs should be sent to nightly. The base branch of this PR has been automatically changed to nightly. Please check that there are no merge conflicts

github-actions[bot] avatar Aug 26 '22 22:08 github-actions[bot]

Thanks for the contribution... once you sign the CLA I will build this version and ask for testers.

ReenigneArcher avatar Aug 27 '22 18:08 ReenigneArcher