Sunshine icon indicating copy to clipboard operation
Sunshine copied to clipboard

fix: print encoder name to info log during creation

Open ns6089 opened this issue 1 year ago • 1 comments

Description

We didn't indicate what encoder we were probing so the log looked very confusing.

Screenshot

[2024-08-05 13:34:51.829] Info: Creating encoder [hevc_nvenc]
[2024-08-05 13:34:51.829] Info: Color coding: SDR (Rec. 709)
[2024-08-05 13:34:51.829] Info: Color depth: 10-bit
[2024-08-05 13:34:51.830] Info: Color range: JPEG

Issues Fixed or Closed

Type of Change

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Dependency update (updates to dependencies)
  • [ ] Documentation update (changes to documentation)
  • [ ] Repository update (changes to repository files, e.g. .github/...)

Checklist

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

ns6089 avatar Aug 05 '24 10:08 ns6089

Codecov Report

Attention: Patch coverage is 8.33333% with 11 lines in your changes missing coverage. Please review.

Project coverage is 9.69%. Comparing base (19250f1) to head (f219a47). Report is 136 commits behind head on master.

Files with missing lines Patch % Lines
src/video.cpp 8.33% 2 Missing and 9 partials :warning:
Additional details and impacted files
@@          Coverage Diff           @@
##           master   #2965   +/-   ##
======================================
  Coverage    9.68%   9.69%           
======================================
  Files          97      97           
  Lines       17528   17524    -4     
  Branches     8200    8204    +4     
======================================
+ Hits         1698    1699    +1     
+ Misses      12993   12987    -6     
- Partials     2837    2838    +1     
Flag Coverage Δ
Linux 7.20% <8.33%> (+0.01%) :arrow_up:
Windows 5.11% <0.00%> (+<0.01%) :arrow_up:
macOS-12 10.37% <0.00%> (+0.01%) :arrow_up:
macOS-13 10.26% <0.00%> (-0.02%) :arrow_down:
macOS-14 10.58% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/video.cpp 25.90% <8.33%> (+0.08%) :arrow_up:

... and 1 file with indirect coverage changes

codecov[bot] avatar Aug 05 '24 14:08 codecov[bot]