LiveTL icon indicating copy to clipboard operation
LiveTL copied to clipboard

Prompt user before updating extension

Open r2dev2 opened this issue 3 years ago • 5 comments

This prompts the user before allowing the extension to update. I currently have no way of testing with actually updating the extension and have been calling my update callback manually.

Fixes #419

r2dev2 avatar Jul 24 '22 07:07 r2dev2

update popup

Let me know if anyone knows how to simulate updating the extension's version. I have tried using the reload button in about:debugging but that just closes the extension even though I am listening to onUpdateAvailable. Updating the package.json did not work either.

r2dev2 avatar Jul 24 '22 07:07 r2dev2

I don't have a PC available to check, but I think the onMount call is erroring, which is why e2e is failing.

runtime.onUpdateAvailable isn't available for content scripts so I would guess it isn't available for pages too.

ChrRubin avatar Jul 24 '22 23:07 ChrRubin

I don't have a PC available to check, but I think the onMount call is erroring, which is why e2e is failing.

runtime.onUpdateAvailable isn't available for content scripts so I would guess it isn't available for pages too.

Where does it say that onUpdateAvailable isn't there for content scripts? I am able to console.log chrome.runtime.onUpdateAvailable from the page.

r2dev2 avatar Jul 25 '22 05:07 r2dev2

https://developer.chrome.com/docs/extensions/mv3/content_scripts/

Who knows if it's different for extension pages, usually it isn't ¯\_(ツ)_/¯

ChrRubin avatar Jul 25 '22 06:07 ChrRubin

Moving to draft as this is low priority and high effort so we can figure it out later, perhaps during the mv3 rework.

r2dev2 avatar Aug 13 '22 06:08 r2dev2