LiveSplitOne icon indicating copy to clipboard operation
LiveSplitOne copied to clipboard

Update how splits are loaded from the leaderboard

Open wooferzfg opened this issue 5 years ago • 8 comments

  • The Run Editor now shows a loading spinner while it's loading splits from the leaderboard.
  • I added a new property to the Run Editor menu state, persistChanges. This determines whether changes made in the Run Editor should immediately be saved to the database or not. We were previously using the splits key to determine this, but we now need that in order to switch between runs while the Run Editor is open.

Fix #362

wooferzfg avatar May 12 '20 03:05 wooferzfg

@CryZe What do we want the behavior to be in this situation?

5dSeawif1t

Currently, I'm giving the imported splits an undefined splits key, which means they don't automatically get persisted to the database.

wooferzfg avatar May 12 '20 03:05 wooferzfg

If you edit splits that aren't open and download splits, it currently replaces the splits in your timer, despite you never "touching your timer". I don't think that's what we want. Honestly, I feel like we long term probably don't even want to have the leaderboard in the run editor. But that's outside the scope of this PR.

CryZe avatar May 12 '20 14:05 CryZe

@CryZe Should we always persist the splits from the leaderboard to the database if you click "OK"? That seems like the least confusing user experience based on what you said.

wooferzfg avatar May 12 '20 18:05 wooferzfg

Yeah I think that may be fine? I'm honestly not sure.

CryZe avatar May 12 '20 18:05 CryZe

Also, I agree that the leaderboard shouldn't be in the Run Editor.

wooferzfg avatar May 12 '20 19:05 wooferzfg

@CryZe Can we merge this? I don't think there are remaining issues with this, at least as a fix for #362.

wooferzfg avatar Jan 18 '21 01:01 wooferzfg

I can re-review this tomorrow maybe.

CryZe avatar Jan 18 '21 01:01 CryZe

@CryZe Could you take a look at the way I'm handling the run editor in this PR? Not sure if I'm disposing it properly everywhere

wooferzfg avatar Apr 17 '24 01:04 wooferzfg