LiveSplit icon indicating copy to clipboard operation
LiveSplit copied to clipboard

Potentially use livesplit-core for the Comparison Generators

Open CryZe opened this issue 8 years ago • 5 comments

The ones in livesplit-core should perform a lot better. This also allows us to run the original ones as well for a while, to verify that the ones in livesplit-core are correctly ported (we'd only do that in the Dev Build). However this also requires some form of synchronization of LiveSplit's Run data with livesplit-core's, which might produce more slowdown than just running LiveSplit's own Comparison Generators.

Alternatively, we could just backport a few performance improvements.

CryZe avatar Jan 10 '18 13:01 CryZe

Isn’t the plan to eventually use lsc’s Run and Timer structs eventually? I feel like this is just a step in that direction

hallcristobal avatar Jan 10 '18 17:01 hallcristobal

It would be a step in that direction. But it's really not clear if we even want to do that, as it would break all kinds of auto splitters and components. So there would need to be a "break" point, where we introduce all of this. But then you may as well just use LiveSplit One at that point, so it's not clear if it's worth it, or if we instead maintain the original LiveSplit as a "well working timer" and treat LSO like OBS Studio which eventually has all the same features and more.

CryZe avatar Jan 10 '18 17:01 CryZe

So introducing less intrusive more isolated changes is a step into that direction, but also doesn't require any breaking changes. So it's much less controversial.

CryZe avatar Jan 10 '18 18:01 CryZe

What's the status on this?

just-ero avatar Apr 18 '24 19:04 just-ero

Same status as before - would be cool to have but not done yet

wooferzfg avatar Apr 18 '24 19:04 wooferzfg