Incorrect AtomicDateTime serialization when serializing Attempt struct to JSON

Open rpgrca opened this issue 3 years ago • 1 comments

Came back to write some more unit tests and noticed the AtomicDateTime does not have a ToString() overload for when an Attempt struct is serialized to JSON, thus serializing to their type name. These methods might not be used right now and thus it might not have been caught still but are latent.

My intention was to only add tests and refrain from fixing code problems so that the PR can be accepted without too much thinking, so I'm documenting this problem to come back and fix it once I PR the tests.

Jan 23 '23 01:01 rpgrca

Hi there, I was wondering if you had the time to review #2308 so that I can fix this bug and continue adding more unit tests to the codebase.

Feb 25 '23 12:02 rpgrca