Alexis Rossfelder
Alexis Rossfelder
> The PR diff size of 21048 lines exceeds the maximum allowed for the inline comments feature. Don't worry buddy, it's gonna be alright.
Marking as draft to give me time to use `NamedTuples` when it's needed
Thing left to do before merging : - [x] Use attrs validators instead of the validate function - [x] Use converters when applicable - [x] Get some actual data on...
I didn't manage to check the NBT for myself in this particular case but I was able to extract some packets and verify that they do not include the name...
I re-ran the tests with basedpyright, everything seems fine
Shouldn't this get merged ?
Ok great, I have been a little busy too. I'll try to make the changes soon !
Can I get assigned on this ?
BTW there are also [configuration](https://wiki.vg/Protocol#Configuration) packets.
I'm not against these new rules as I feel they are not the most annoying of the bunch, but I don't really know if the extra effort is worth the...